Add a message to Trust checks if not a trust agent/controller

[rcritten]

Previously it would return an empty SUCCESS message because if the server is not an agent and/or controller role then there is nothing to do. So return a message that indicates this.

Note: this is a change in behavior. The test used to be skipped altogether so returned no result at all. Returning a result will help ensure that all tests were executed.

Fixes: #85

Summary by Sourcery

Return a success result with an explanatory message for all trust checks when the server is not a trust agent or controller, ensuring skipped tests still produce a result.

Enhancements:

• Have each trust agent and controller plugin yield a SUCCESS result with a “Skipped. Not a trust agent/controller” message instead of silently skipping.

Tests:

• Update trust-related tests to expect one SUCCESS result with the skip message instead of zero results for skipped scenarios.

[sourcery-ai]

Hey @rcritten - I've reviewed your changes - here's some feedback:

• Consider extracting the repeated skip logic (yielding Result(self, SUCCESS, …) and return) into a shared helper or base method so you don’t have to copy it into every check class.
• Define the skip messages (e.g. “Skipped. Not a trust agent” / “Skipped. Not a trust controller”) as constants or via a helper function to guarantee consistency and simplify future updates.
• Double-check message formatting (capitalization, punctuation) against project style guidelines to ensure the new SUCCESS messages are uniform across all checks.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider extracting the repeated skip logic (yielding Result(self, SUCCESS, …) and return) into a shared helper or base method so you don’t have to copy it into every check class.
- Define the skip messages (e.g. “Skipped. Not a trust agent” / “Skipped. Not a trust controller”) as constants or via a helper function to guarantee consistency and simplify future updates.
- Double-check message formatting (capitalization, punctuation) against project style guidelines to ensure the new SUCCESS messages are uniform across all checks.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[frasertweedale]

Reviewed and tested. ACK.