Refactor parse-multipart
#36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate to TypeScript * Add unit tests * Add support for parsing `name` fields from Content-Disposition * Fix bug when `filename` field was absent in Content-Disposition * Fix spelling/grammar mistakes in README.md
Author
|
👋🏻 @christiansalazar – I'm happy to continue to use my fork of the package, but I'm wondering if there's any interest in merging this? |
Contributor
|
Hi, yes. Thanku for rememebrring this. Will do soon. Will notify You also.
El vie., 22 de marzo de 2024 7:23 p. m., Cameron Hunter <
***@***.***> escribió:
… 👋🏻 @christiansalazar <https://github.com/christiansalazar> – I'm happy
to continue to use my fork of the package, but I'm wondering if there's any
interest in merging this?
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMTRA4P3IKGWMZVN5JDZ6LYZSVN5AVCNFSM6AAAAABEC5ABRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGAYTOOJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Hi, I was using your library and ran into a bug when the Content-Disposition didn't include a
filename. The parsed objects also didn't include thenamefield which was important for my use case.What's Changed?
namefields from Content-Dispositionfilenamefield was absent in Content-Disposition