Skip to content

Ignore superfluous T38_FIELD_HDLC_SIG_END sent by some implementations #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore superfluous T38_FIELD_HDLC_SIG_END sent by some implementations #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/t31.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,10 @@ static int process_rx_data(t38_core_state_t *t, void *user_data, int data_type,
/*endif*/
/* Some T.38 implementations send multiple T38_FIELD_HDLC_SIG_END messages, in IFP packets with
incrementing sequence numbers, which are actually repeats. They get through to this point because
of the incrementing sequence numbers. We need to filter them here in a context sensitive manner. */
if (t->current_rx_data_type != data_type || t->current_rx_field_type != field_type)
of the incrementing sequence numbers. Some others send T38_FIELD_HDLC_SIG_END following a
T38_FIELD_HDLC_FCS_OK_SIG_END or T38_FIELD_HDLC_FCS_BAD_SIG_END. We need to filter them here
in a context sensitive manner. */
if (t->current_rx_data_type != data_type || (t->current_rx_field_type != field_type && t->current_rx_field_type != T38_FIELD_HDLC_FCS_OK_SIG_END && t->current_rx_field_type != T38_FIELD_HDLC_FCS_BAD_SIG_END))
{
/* WORKAROUND: At least some Mediatrix boxes have a bug, where they can send this message at the
end of non-ECM data. We need to tolerate this. We use the generic receive complete
Expand Down
6 changes: 4 additions & 2 deletions src/t38_gateway.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,8 +1308,10 @@ static int process_rx_data(t38_core_state_t *t, void *user_data, int data_type,
/*endif*/
/* Some T.38 implementations send multiple T38_FIELD_HDLC_SIG_END messages, in IFP packets with
incrementing sequence numbers, which are actually repeats. They get through to this point because
of the incrementing sequence numbers. We need to filter them here in a context sensitive manner. */
if (t->current_rx_data_type != data_type || t->current_rx_field_type != field_type)
of the incrementing sequence numbers. Some others send T38_FIELD_HDLC_SIG_END following a
T38_FIELD_HDLC_FCS_OK_SIG_END or T38_FIELD_HDLC_FCS_BAD_SIG_END. We need to filter them here
in a context sensitive manner. */
if (t->current_rx_data_type != data_type || (t->current_rx_field_type != field_type && t->current_rx_field_type != T38_FIELD_HDLC_FCS_OK_SIG_END && t->current_rx_field_type != T38_FIELD_HDLC_FCS_BAD_SIG_END))
{
if (hdlc_buf->contents != (data_type | FLAG_DATA))
{
Expand Down
6 changes: 4 additions & 2 deletions src/t38_terminal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,10 @@ static int process_rx_data(t38_core_state_t *t, void *user_data, int data_type,
/*endif*/
/* Some T.38 implementations send multiple T38_FIELD_HDLC_SIG_END messages, in IFP packets with
incrementing sequence numbers, which are actually repeats. They get through to this point because
of the incrementing sequence numbers. We need to filter them here in a context sensitive manner. */
if (t->current_rx_data_type != data_type || t->current_rx_field_type != field_type)
of the incrementing sequence numbers. Some others send T38_FIELD_HDLC_SIG_END following a
T38_FIELD_HDLC_FCS_OK_SIG_END or T38_FIELD_HDLC_FCS_BAD_SIG_END. We need to filter them here
in a context sensitive manner. */
if (t->current_rx_data_type != data_type || (t->current_rx_field_type != field_type && t->current_rx_field_type != T38_FIELD_HDLC_FCS_OK_SIG_END && t->current_rx_field_type != T38_FIELD_HDLC_FCS_BAD_SIG_END))
{
/* WORKAROUND: At least some Mediatrix boxes have a bug, where they can send this message at the
end of non-ECM data. We need to tolerate this. We use the generic receive complete
Expand Down