-
Notifications
You must be signed in to change notification settings - Fork 21
Design Doc: Provider Contexts #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great! Thanks!
…implifies POV concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few final thoughts and questions, but I think we are good to merge, make issues, and figure out the rest of it along the way.
```rust | ||
#[pallet::call_index(1)] | ||
pub fn propose_to_add_application( | ||
origin: OriginFor<T>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilwade should we separate add and update as separate extrinsics, assuming we can handle both with an optional application index
On similar lines do we enable updating provider data via governance in same fashion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm....
- I think we can just make them set functions. Simplifies the setup.
- Re-Provider Data. This makes me wonder again about an
Application 0
default instead of having Provider Data and Application data. Is there any other way we could unify these? Perhaps apropose_to_set_provider_application
that takes an optional application id and if no application id it sets the provider level? Not sure if that makes it more confusing over having two extrinsics or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilwade we can enforce a default application (atleast 1) to exists and using provider data we can create one on registration. Provider may choose to update it later but the provider data tied to provider registry wont be updated? That way we are'nt making it overly complex
What you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can see how that works, but we do want to be able to update the provider information as well so not sure it gets us far unless we just "don't" have provider information and only have application information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, it's better if we can just follow same model on both applications and provider side for issuing updates that way it's more nuanced even with some extra code.
I will capture that in this document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed most technical details and decisions, design may change during implementation.
Goal
The goal of this PR is to layout a design doc for storing Provider Contexts on chain. This would allow a provider to have one or more applications and provider user consumed logos and names (in multiple languages).
Closes #2269