feat: implement pallet_msa::withdraw_tokens extrinsic #2402

JoeCap08055 · 2025-05-12T21:14:45Z

Goal

The goal of this PR is to implement a withdraw_tokens extrinsic that allows MSAs holding tokens to authorize their tokens to be withdrawn to a specified account.

Closes #2388

Discussion

Checklist

codecov · 2025-05-13T15:32:07Z

Codecov Report

Attention: Patch coverage is 97.93103% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pallets/msa/src/lib.rs	98.23%	2 Missing ⚠️
pallets/msa/src/types.rs	96.87%	1 Missing ⚠️

Files with missing lines	Coverage Δ
pallets/msa/src/types.rs	`97.74% <96.87%> (-0.28%)`	⬇️
pallets/msa/src/lib.rs	`93.29% <98.23%> (+0.54%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pallets/msa/Cargo.toml

pallets/msa/src/lib.rs

shannonwells

I had just the nitpick comment but nothing blocking. Lots of good work!

pallets/msa/src/lib.rs

…1.85+

.github/workflows/verify-pr-commit.yml

mattheworris

Read through changes and looked into cargo deny.
Nice work.
🚢 it!

pallets/msa/src/lib.rs

pallets/msa/src/tests/msa_token_tests.rs

enddynayn

Nice work here 👍 ! Definitely not a simple PR.

aramikm · 2025-06-11T18:19:34Z

pallets/msa/src/lib.rs

+		pub fn withdraw_tokens(
+			origin: OriginFor<T>,
+			_msa_owner_public_key: T::AccountId,
+			msa_owner_proof: MultiSignature,


I think we might need to comments in here that mentioned that the proof check is done inside the extension so we don't need to do it here.

feat: implement pallet_msa::withdraw_tokens extrinsic

49116ab

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 12, 2025

JoeCap08055 added 2 commits May 13, 2025 11:17

fix: doc lint

563baed

fix: broken unit tests

a7ac8db

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 13, 2025

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 13, 2025

feat: bump spec version

551c6c5

JoeCap08055 added 2 commits May 13, 2025 12:59

fix: update MSA pallet README

6a19e64

feat: unit tests

b57132e

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label May 13, 2025

JoeCap08055 added 3 commits May 13, 2025 17:25

feat: add benchmarks for withdraw_tokens extrinsic

1e78244

Merge branch 'main' into feat/withdraw-tokens-from-msa

582d13d

fix: fix payload signature verification after merge EIP-712 from main

0363457

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels May 13, 2025

aramikm reviewed May 13, 2025

View reviewed changes

pallets/msa/Cargo.toml Outdated Show resolved Hide resolved

pallets/msa/src/lib.rs Outdated Show resolved Hide resolved

pallets/msa/src/lib.rs Outdated Show resolved Hide resolved

pallets/msa/src/lib.rs Show resolved Hide resolved

JoeCap08055 added 2 commits May 14, 2025 09:43

fix: bump spec version

1c7328f

fix: formatting

fa04839

JoeCap08055 marked this pull request as ready for review May 14, 2025 16:33

JoeCap08055 requested a review from wilwade as a code owner May 14, 2025 16:33

Update weights

311dbfc

shannonwells approved these changes May 30, 2025

View reviewed changes

pallets/msa/src/lib.rs Outdated Show resolved Hide resolved

Merge branch 'main' into feat/withdraw-tokens-from-msa

aa07490

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 1, 2025

JoeCap08055 added 2 commits June 3, 2025 14:55

fix: cargo fmt

0d34cd8

Merge branch 'main' into feat/withdraw-tokens-from-msa

a7d52af

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 4, 2025

fix: PR comments

22cca43

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 4, 2025

fix: missing js imports in e2e

2d09e92

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 6, 2025

fix: use nightly Rust toolchain for cargo deny until we move to Rust …

7bcabfd

…1.85+

JoeCap08055 requested a review from demisx as a code owner June 6, 2025 14:40

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 6, 2025

mattheworris reviewed Jun 9, 2025

View reviewed changes

.github/workflows/verify-pr-commit.yml Outdated Show resolved Hide resolved

mattheworris approved these changes Jun 9, 2025

View reviewed changes

enddynayn reviewed Jun 11, 2025

View reviewed changes

pallets/msa/src/lib.rs Show resolved Hide resolved

enddynayn reviewed Jun 11, 2025

View reviewed changes

pallets/msa/src/tests/msa_token_tests.rs Show resolved Hide resolved

fix: lock base64ct package version to fix cargo deny in CI

cb3ec89

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 11, 2025

enddynayn approved these changes Jun 11, 2025

View reviewed changes

fix: update lock file

ceb9636

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 11, 2025

JoeCap08055 merged commit 1b8782f into main Jun 11, 2025
34 checks passed

JoeCap08055 deleted the feat/withdraw-tokens-from-msa branch June 11, 2025 17:07

aramikm reviewed Jun 11, 2025

View reviewed changes

aramikm approved these changes Jun 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: implement pallet_msa::withdraw_tokens extrinsic #2402

feat: implement pallet_msa::withdraw_tokens extrinsic #2402

Uh oh!

JoeCap08055 commented May 12, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shannonwells left a comment

Uh oh!

Uh oh!

Uh oh!

mattheworris left a comment

Uh oh!

Uh oh!

Uh oh!

enddynayn left a comment

Uh oh!

Uh oh!

aramikm Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

feat: implement pallet_msa::withdraw_tokens extrinsic #2402

feat: implement pallet_msa::withdraw_tokens extrinsic #2402

Uh oh!

Conversation

JoeCap08055 commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Discussion

Checklist

Uh oh!

codecov bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shannonwells left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattheworris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

enddynayn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aramikm Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoeCap08055 commented May 12, 2025 •

edited

Loading

codecov bot commented May 13, 2025 •

edited

Loading

aramikm Jun 11, 2025 •

edited

Loading