Skip to content

Conversation

@friedger
Copy link
Owner

No description provided.

Zeus-Adin added 25 commits April 1, 2025 14:53
…ion contract for user's since the delegaticontract is specific to each smart-wallet
…ion contract for user's since the delegaticontract is specific to each smart-wallet
…ion contract for user's since the delegaticontract is specific to each smart-wallet
…ion contract for user's since the delegaticontract is specific to each smart-wallet
…ion contract for user's since the delegaticontract is specific to each smart-wallet
@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2025 0:47am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UI and wallet service logic by refining wallet-related functions, enhancing error handling, and streamlining the user experience within wallet modals and components.

  • Refactored wallet service functions (getConfig, deployContract, delegate) and removed stx rate fetching from balance functions.
  • Updated several UI components (wallet page, modals, wallet transfer, wallet assets) to improve integration and usability.
  • Made adjustments to the storage service and constants while removing deprecated elements.

Reviewed Changes

Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/src/services/wallet.js Updated wallet services with new functions and refactored error handling; added deployContract and delegate functions.
ui/src/services/storage.js Modified storage functions with encryption/decryption and improved error handling.
ui/src/services/rates.js Added a new rates service for fetching coingecko data.
ui/src/pages/wallet.jsx Refactored wallet page initialization and modal trigger logic.
ui/src/components/* Numerous UI adjustments in modals, wallet transfer, assets, and smart wallet balance components.
ui/src/lib/constants.js Updated constants to include new contract addresses.
Files not reviewed (4)
  • clarity/contracts/extensions/ext-delegate-stx-pox-4.clar: Language not supported
  • ui/package-lock.json: Language not supported
  • ui/package.json: Language not supported
  • ui/public/ext-delegate-stx-pox-4.clar: Language not supported
Comments suppressed due to low confidence (6)

ui/src/components/wallettransfer.jsx:30

  • The updater function 'setAdress' is misspelled; it should be 'setAddress'.
const [address, setAdress] = useState('');

ui/src/services/wallet.js:135

  • The variable 'success' is used in the onFinish callback of deployContract but is not defined. Consider retrieving the success status from the response or removing the conditional check.
if (success) {

ui/src/services/wallet.js:155

  • The function 'hexToUint8Array' is used but not defined or imported. Consider defining or importing the correct function to convert hexadecimal strings to a Uint8Array.
const serializedPayload = hexToUint8Array(serializeCV(

ui/src/services/storage.js:14

  • In the catch block of savetoGaia, 'res' is referenced instead of the error variable. It should likely use 'err' to determine success.
result.success = Boolean(res);

ui/src/components/modal/stxsendmodal.jsx:17

  • The variable 'isDiabled' is misspelled; it should be 'isDisabled' for clarity and consistency.
const [isDiabled, setIsDisabled] = useState(false);

ui/src/components/modal/smartwalletdeploymodal.jsx:15

  • [nitpick] The updater function 'setOverRide' is inconsistently capitalized; consider renaming it to 'setOverride' to match standard naming conventions.
const [override, setOverRide] = useState(false);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants