-
Notifications
You must be signed in to change notification settings - Fork 12
Execute tests against PHP8.3 and allow compatibility with phpunit/php-code-coverage v11.* #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jaylinski it looks like the Do you think it's relevant to support v11 today ? Maybe I must split this PR in two distinct ones (one for PHP and one for PHPUnit upgrade…). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should support v11. Seems we only have to use the includeFiles()
-method instead (or add includeDirectory()
on our own).
sebastianbergmann/php-code-coverage@8fdb7ff
Do you wanna fix it? I can do it too.
I already started working on the change. My main concern is that we can't have a the |
That is true, I didn't notice that there is no workaround for the I'm also not opposed to dropping the |
Hi there. Any update on this PR? |
Hello ! Sorry, nothing new here, I hadn't time to work on that part yet… |
9555d33
to
e4c650f
Compare
Hello @jaylinski ! I’ve updated this MR to only check against PHP 8.3. I opened #61 to handle the PHPUnit v11 update. |
Just updated the CI configuration to test against PHP8.3 and refine some composer dependencies rules.