Skip to content

Execute tests against PHP8.3 and allow compatibility with phpunit/php-code-coverage v11.* #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

shulard
Copy link
Member

@shulard shulard commented Mar 6, 2024

Just updated the CI configuration to test against PHP8.3 and refine some composer dependencies rules.

@shulard shulard self-assigned this Mar 6, 2024
@shulard shulard requested a review from jaylinski March 6, 2024 09:13
@shulard
Copy link
Member Author

shulard commented Mar 6, 2024

@jaylinski it looks like the phpunit/php-spec-coverage package doesn't expose some methods anymore in version 11.*: https://github.com/sebastianbergmann/php-code-coverage/blob/11.0.1/ChangeLog-11.0.md

Do you think it's relevant to support v11 today ? Maybe I must split this PR in two distinct ones (one for PHP and one for PHPUnit upgrade…).

Copy link
Member

@jaylinski jaylinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support v11. Seems we only have to use the includeFiles()-method instead (or add includeDirectory() on our own).

sebastianbergmann/php-code-coverage@8fdb7ff

Do you wanna fix it? I can do it too.

@shulard
Copy link
Member Author

shulard commented Mar 8, 2024

I already started working on the change.

My main concern is that we can't have a the blacklist and blacklist_files options anymore. The change regarding include is pretty straightforward but the exclude can't be implemented anymore. I don't know if it's a big deal or not (I don't use any exclude on my side…).

@jaylinski
Copy link
Member

jaylinski commented Mar 8, 2024

I already started working on the change.

My main concern is that we can't have a the blacklist and blacklist_files options anymore. The change regarding include is pretty straightforward but the exclude can't be implemented anymore. I don't know if it's a big deal or not (I don't use any exclude on my side…).

That is true, I didn't notice that there is no workaround for the exclude*-functions. Can we implement it ourselves by only including files that are not in the excludes-list? 🤔

I'm also not opposed to dropping the blacklist-feature and doing a new major release (and also dropping EOL PHP versions).

@balazscsaba2006
Copy link

Hi there. Any update on this PR?

@shulard
Copy link
Member Author

shulard commented Jul 12, 2024

Hello !

Sorry, nothing new here, I hadn't time to work on that part yet…

@shulard shulard force-pushed the chore/php-support branch from 9555d33 to e4c650f Compare July 15, 2024 11:14
@shulard
Copy link
Member Author

shulard commented Jul 15, 2024

Hello @jaylinski !

I’ve updated this MR to only check against PHP 8.3.

I opened #61 to handle the PHPUnit v11 update.

@shulard shulard merged commit 14ca8bb into master Jul 16, 2024
147 checks passed
@shulard shulard mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants