-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arduino platform #4181
base: develop
Are you sure you want to change the base?
Fix arduino platform #4181
Conversation
…xisting users. Arduino IDE 2.x seems to not support comand line commands. Fixes fritzing#4010
…I) instead of the Arduino IDE (Arduino 1.x still works, but 2.x does not). So, let's push users to use the Arduino CLI.
auto * process = new QProcess(this); | ||
QStringList args; | ||
args.append(QString("--board")); | ||
args.append(QString(" sssssss")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use something like "arduino-cli version" instead of producing a weird error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, try to give feedback a bit faster. I forgot what I did that and had to spend time checking this again.
The issue is that I wanted to create an error. You can try to just have an argument "version". If you do that, you must read the standard output and not the error and then it works well if you have arduino-cli. But it will open a new
Arduino-IDE and generate a message (not able to open "version" sketch) when the Arduino IDE 1.x is used as programmer. Thus, if you do not create an error and you are using Arduino IDE (1.x), it will launch a new Arduino IDE every time you press program. If there is an error, the Arduino IDE is not launched.
Not very elegant, but it works well with arduino-cli and Arduino IDE 1.x. Of course, we could drop the support for the Arduino IDE 1.x too, but that is your decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine then, I agree we shouldn't launching the IDE just to probe it.
|
No description provided.