Remove asset precompile config initializer#81
Open
javierjulio wants to merge 1 commit intofroala:masterfrom
Open
Remove asset precompile config initializer#81javierjulio wants to merge 1 commit intofroala:masterfrom
javierjulio wants to merge 1 commit intofroala:masterfrom
Conversation
Author
|
UPDATE: tests now passing There is only one build failure: Ruby 1.9.3 where it can't seem to find a download. It seems this version isn't available. This is affecting all builds for awhile now. Note there are several release commits in master with the same failed builds. |
585d00d to
d323fd6
Compare
This is unnecessary as an asset gem. As shown in the docs for wysiwyg-rails, these files are required in manifest files that are part of a Rails applications' precompile config. There is no need to also precompile these files too which causes a very large amount of files being generated when running `rails assets:precompile` (an extra file for each due to GZ).
d323fd6 to
6047434
Compare
Author
|
Rebased. All tests are now passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unnecessary as an asset gem. As shown in the docs for
wysiwyg-railsgem, these files are required in manifest files that are already part of a Rails applications' precompile config. There is no need to also precompile these files too which causes a very large amount of files being generated when runningrails assets:precompile(an extra file for each due to GZ).I'm able to update or include any other changes that are necessary, just let me know. Happy to help. This resolves #56 which should be reopened. Update: created a new issue in #83.
Fixes #83