Rfc9293 WIP #202
Open
Rfc9293 WIP #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:ack-p t is the default.
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
| (challenge-ack connection)) | ||
| ((logtest flags +tcp4-flag-ack+) | ||
| (detach-tcp-connection connection)))) | ||
| ((not (logtest flags +tcp4-flag-ack+))) ; Ignore packets without ACK set. |
There was a problem hiding this comment.
Typo in the commit message for this one. Not commenting on the logic in the change.
fitzsim
reviewed
Jul 14, 2024
| (t | ||
| (when (eql ack (tcp-connection-snd.nxt connection)) | ||
| (detach-tcp-connection connection))))) | ||
| (detach-tcp-connection connection)) |
There was a problem hiding this comment.
Another typo in this commit message.
fitzsim
reviewed
Jul 14, 2024
| (eql seq (tcp-connection-rcv.nxt connection))) | ||
| (setf (tcp-connection-rcv.nxt connection) (+u32 seq 1) | ||
| (tcp-connection-state connection) :close-wait) | ||
| (setf (tcp-connection-state connection) :close-wait |
There was a problem hiding this comment.
Typo in commit message: "resive".
fitzsim
reviewed
Jul 14, 2024
|
|
||
| (defun arp-expiration () | ||
| (let ((time (1+ (get-internal-real-time)))) | ||
| (let ((time (1+ (get-universal-time)))) |
There was a problem hiding this comment.
Is it an option to use internal-real-time throughout arp.lisp instead? Is get-universal-time monotonic, or can it change backwards when setting the system date/time (in which case it should not be used for ARP timeouts).
Fixes crash when accepting listener connection
- Reorganized code with section headers for better structure - Added detailed comments for constants and parameters - Replaced hardcoded MSS values with *default-max-seg-size* and *max-seg-size* - Replaced `(when (not ...))` with `(unless ...)` for readability - Improved documentation of TCP flags and options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.