Added install dependencies & tests setup#33
Merged
ma-oliveiramarques merged 2 commits intomasterfrom May 2, 2022
Merged
Conversation
pncsoares
requested changes
May 2, 2022
README.md
Outdated
| ``` | ||
| Jest | ||
| ```bash | ||
| npm install --save-dev jest |
Member
There was a problem hiding this comment.
This is unnecessary because the one who clone this repo just need to run npm install or npm i to install all the dependencies present in the package.json file
Contributor
Author
There was a problem hiding this comment.
Right! Should I keep the npm test??
Member
There was a problem hiding this comment.
Right! Should I keep the npm test??
Yes because someone who clone this repo should run the tests in order to prove or just to see if the tests pass.
pncsoares
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to document tests && improve readme file.
Close #15