Skip to content

Cache busting (Was: Some questions/remarks after viewing the source code) #382

Description

@bnijenhuis

Not sure where to put this, so I figured this was the best place (because 'Discussions' isn't used). I was just looking at the source code of the homepage, and I have some questions:

  • The alternate link meta-tag is incorrect (just redirects to the same page, instead of the EN page):
    <link rel="alternate" hreflang="en-US" href="/">;
  • Why are the fonts loaded inline in the head? They are in the CSS as well;
  • Why is an random string added to the CSS link with JS? This is bypassing the cache (if I read it correctly).
  • If it's for forcing a reload of the CSS if there was a change, there's a better way of doing that (wrote about it on https://bnijenhuis.nl/notes/cache-busting-in-eleventy/)
  • Why are all the clippaths in the HTML?

To be clear, this is not meant as criticism, although it could come over as such. I haven't been involved in implementing everything, so it's not my place to criticize, but I was just wondering what the reasoning is behind some choices. Or maybe it was just overlooked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions