Skip to content

Added method to handle remote key events to show controls on any keypress #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FGMGIT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added method to handle remote key events to show controls on any keypress #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/android/Player.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ public void onDismiss(DialogInterface dialog) {
public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) {
JSONObject payload = Payload.keyEvent(event);
new CallbackResponse(Player.this.callbackContext).send(PluginResult.Status.OK, payload, true);

//Added method to handle remote key events to show controls on any key event
exoView.showController();
Copy link
Owner

@frontyard frontyard Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only show ExoPlayer's controller on the bottom. We also have to support info header on the top which needs to be synchronized with the bottom controlller.

Can you take a look at onTouchListener and see if you can make it work in similar fashion?

Copy link
Author

@FGMGIT FGMGIT Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment we are not using the info header, I was trying to implement the same method used in onTouchListener with no results. I'll come back to it when we need to use info header or when I find some time.

Copy link

@mkalyon mkalyon Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added after exoView.showController();
show();
show info header on key events.

Copy link
Owner

@frontyard frontyard Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkalyon @FGMGIT is this still an issue? What's the proper way to fix this issue?


return false;
}
};
Expand Down