Add totalRolls to iArtifact, UI and editor - #3055
Conversation
|
[frontend] [Thu Sep 18 13:15:33 UTC 2025] - Deployed 0577e48 to https://genshin-optimizer-prs.github.io/pr/3055/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Sep 20 00:03:40 UTC 2025] - Deployed 3339487 to https://genshin-optimizer-prs.github.io/pr/3055/frontend (Takes 3-5 minutes after this completes to be available) |
| ? allElementWithPhyKeys.find((ele) => artifact.mainStatKey.includes(ele)) | ||
| : undefined | ||
| const color = artifact ? (element ?? 'success') : 'primary' | ||
| const guessedRolls = cArtifact?.substats.reduce( |
There was a problem hiding this comment.
Not sure if it is easily doable, but what I was hoping for is if the rolls we calculated in ArtifactDataManager.ts only have one combination (e.g. it can only be an 8 roll artifact), this would be considered non-guessed and reflect properly in the UI and data representation. For example, I added this artifact, and there is 0 way for this to be anytthing but 9 total rolls, so it shouldn't be guessed anymore
2 participants
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.