forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 1
Rileytb/eolbfrst 921 hf inj react webpack setup #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rileytb
wants to merge
205
commits into
frontierMaster
from
rileytb/EOLBFRST-921_-hf-inj-react-webpack-setup
Closed
Rileytb/eolbfrst 921 hf inj react webpack setup #379
rileytb
wants to merge
205
commits into
frontierMaster
from
rileytb/EOLBFRST-921_-hf-inj-react-webpack-setup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook v2.1.3
merge upstream master
merging upstream master
…into facebook-master
* Adopt Contributor Covenant * Add link to Contributor Covenant to docs site
- use ESLint cache - remove useless `watch` option in fork-ts-checker
Add blog post that takes a React developer step-by-step through many features of AWS. Blog post is suitable for a beginner to follow and have a production ready workflow.
Update adding-a-router.md
Update links in `README`
Chore: Update document to GitHub default branch
Update URL Co-authored-by: Nurlan Suyundukov <[email protected]>
Updated pace.js link
…rn/minimist-1.2.6 Bump minimist from 1.2.5 to 1.2.6
…ook_instructions Chore: (Docs) Updates for the Storybook docs
docs: Make hyperlink consistent
docs: update jest links
When adding typescript to an existing Create React App project you have to have tsconfig.json in the project, I believe this change should clarify it for beginners getting stuck on this step. Not sure if providing an example would be too much so I have added a link to the tsconfig.json instead.
Add a link to React Router docs specific to adding routes.
Remove reference to deprecated VSCode debugger plugin. https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-chrome
fix code splitting link
fix broken link progressive web app
docs: Add Link to Adding Routes Docs
update the heroku buildpack link
Add missing instruction if you are adding typescript
VSCode debugger plugin deprecated
…nto facebook-main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
REACT_APP_INJECT_STYLES
to control injecting styles into a window variable (which is then used within hf-inj-react to inject them into the shadow DOM for the zion header/footer)