-
Notifications
You must be signed in to change notification settings - Fork 417
add .size() to ArrowFile #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−11
Merged
add .size() to ArrowFile #1944
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2b14563
Update size parameter to accept callable
OneSizeFitsQuorum 29e2ae8
add test
OneSizeFitsQuorum d80b655
Merge branch 'master' of github.com:fsspec/filesystem_spec into patch-1
OneSizeFitsQuorum 41d05fd
fix
OneSizeFitsQuorum 0aa6da5
fix review
OneSizeFitsQuorum 0d7a8ff
fix ut
OneSizeFitsQuorum 8cfb352
test
OneSizeFitsQuorum 3b3906c
add back
OneSizeFitsQuorum 0e8a801
Remove 'size' method from ArrowFile
OneSizeFitsQuorum 2f8523f
fix ut
OneSizeFitsQuorum 4644bbd
fix ut
OneSizeFitsQuorum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we
get()the file just because it's not seekable? Isn't that exactly what the code before this PR was doing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we call size() inside the get_file()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can read a stream until it's done. We don't want that workflow to become unusable.