Skip to content

add .size() to ArrowFile #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 21, 2025
+12 −11
Merged

add .size() to ArrowFile #1944

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2b14563
Update size parameter to accept callable
OneSizeFitsQuorum Nov 5, 2025
29e2ae8
add test
OneSizeFitsQuorum Nov 17, 2025
d80b655
Merge branch 'master' of github.com:fsspec/filesystem_spec into patch-1
OneSizeFitsQuorum Nov 17, 2025
41d05fd
fix
OneSizeFitsQuorum Nov 17, 2025
0aa6da5
fix review
OneSizeFitsQuorum Nov 19, 2025
0d7a8ff
fix ut
OneSizeFitsQuorum Nov 19, 2025
8cfb352
test
OneSizeFitsQuorum Nov 19, 2025
3b3906c
add back
OneSizeFitsQuorum Nov 19, 2025
0e8a801
Remove 'size' method from ArrowFile
OneSizeFitsQuorum Nov 20, 2025
2f8523f
fix ut
OneSizeFitsQuorum Nov 20, 2025
4644bbd
fix ut
OneSizeFitsQuorum Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions fsspec/implementations/tests/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,8 @@ def test_get_file_seekable_default(fs, remote_dir, tmp_path):

# Test default behavior (seekable=False)
local_file = tmp_path / "test_default.txt"
fs.get_file(remote_dir + "/test_file.txt", str(local_file))
with open(local_file, "rb") as f:
assert f.read() == data
with pytest.raises(OSError, match="only valid on seekable files"):
Copy link
Member

@martindurant martindurant Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we get() the file just because it's not seekable? Isn't that exactly what the code before this PR was doing?

Copy link
Contributor Author

@OneSizeFitsQuorum OneSizeFitsQuorum Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we call size() inside the get_file()

Copy link
Member

@martindurant martindurant Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we can read a stream until it's done. We don't want that workflow to become unusable.

fs.get_file(remote_dir + "/test_file.txt", str(local_file))

# Test with explicit seekable=True
local_file_seekable = tmp_path / "test_seekable.txt"
Expand All @@ -292,11 +291,10 @@ def test_get_file_seekable_default(fs, remote_dir, tmp_path):

# Test with explicit seekable=False
local_file_not_seekable = tmp_path / "test_not_seekable.txt"
fs.get_file(
remote_dir + "/test_file.txt", str(local_file_not_seekable), seekable=False
)
with open(local_file_not_seekable, "rb") as f:
assert f.read() == data
with pytest.raises(OSError, match="only valid on seekable files"):
fs.get_file(
remote_dir + "/test_file.txt", str(local_file_not_seekable), seekable=False
)


def test_cat_file_seekable_override(fs, remote_dir):
Expand Down
Loading