Skip to content

Update to binary prefix file size, Add directory children count #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Jul 11, 2025

  • Update file size with binary prefixes
  • Add directory children count

Addresses #151

@RRosio RRosio added the enhancement New feature or request label Jul 11, 2025
@RRosio RRosio linked an issue Jul 11, 2025 that may be closed by this pull request
@RRosio
Copy link
Collaborator Author

RRosio commented Jul 11, 2025

Something that came up when attempting to add the directory children count, is that we are lazy loading directory items, as such we do not currently have a count of the number of children in a directory.

One possibility is to only include that count once the directory has been loaded? However, I am not sure that provides the value that is intended for the user....

@martindurant
Copy link
Member

One possibility is to only include that count once the directory has been loaded?

That's what I was thinking, but agree that it might look weird and not be all that useful.

@RRosio
Copy link
Collaborator Author

RRosio commented Jul 11, 2025

That's what I was thinking, but agree that it might look weird and not be all that useful.

For now, I've updated to only display the item count once the items have been loaded. If that seems unnecessary we can always remove it later on.... For reference it currently looks like:

Screenshot 2025-07-11 at 11 39 28 AM

@RRosio RRosio marked this pull request as ready for review July 11, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update file size formatting and directory child count display
2 participants