Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Theta Cfa Generator #92

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

radl97
Copy link
Contributor

@radl97 radl97 commented Feb 7, 2021

This is the first patch aiming to enable generating Theta-XCFA.

This PR refactors the monolith that is ThetaCfaGenerator.

@radl97 radl97 requested a review from sallaigy February 7, 2021 16:20
@radl97 radl97 self-assigned this Feb 7, 2021
@radl97 radl97 force-pushed the refactor-theta-cfa-generator branch from 453d2e0 to 824c9f7 Compare February 7, 2021 16:28
@radl97 radl97 marked this pull request as draft February 7, 2021 17:04
@radl97 radl97 removed the request for review from sallaigy February 7, 2021 17:04
@radl97 radl97 force-pushed the refactor-theta-cfa-generator branch from 824c9f7 to 26f5347 Compare February 7, 2021 17:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radl97
Copy link
Contributor Author

radl97 commented Feb 7, 2021

Refactored it, sorry

@radl97 radl97 marked this pull request as ready for review February 7, 2021 18:58
@radl97 radl97 requested review from sallaigy and AdamZsofi February 7, 2021 18:58
Copy link
Member

@sallaigy sallaigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I left some minor comments to tackle :)

@@ -1,47 +0,0 @@
main process __gazer_main_process {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this file. Could we perhaps add a .gitignore into test/theta so that the Output directory is ignored and we can avoid commiting files like this again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@radl97 radl97 force-pushed the refactor-theta-cfa-generator branch from 3660b54 to 8997e05 Compare February 10, 2021 10:18
@radl97 radl97 requested a review from sallaigy February 10, 2021 12:12
Copy link
Member

@AdamZsofi AdamZsofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find anything, that wasn't mentioned already, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants