-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Theta Cfa Generator #92
base: master
Are you sure you want to change the base?
Conversation
453d2e0
to
824c9f7
Compare
824c9f7
to
26f5347
Compare
Kudos, SonarCloud Quality Gate passed! |
Refactored it, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I left some minor comments to tackle :)
@@ -1,47 +0,0 @@ | |||
main process __gazer_main_process { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this file. Could we perhaps add a .gitignore
into test/theta
so that the Output
directory is ignored and we can avoid commiting files like this again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Gyula Sallai <[email protected]>
3660b54
to
8997e05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find anything, that wasn't mentioned already, nice work.
This is the first patch aiming to enable generating Theta-XCFA.
This PR refactors the monolith that is ThetaCfaGenerator.