Skip to content

Fix issues raised

Fix issues raised #13

Triggered via pull request November 3, 2024 17:32
@as3810tas3810t
synchronize #1
pr-check
Status Failure
Total duration 1m 0s
Billable time 4m
Artifacts 1

PR.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
coverage
The code coverage is too low: 87.61. Expected at least 90.
solhint: contracts/MallorysMaliciousMisappropriation.sol#L20
[solhint] reported by reviewdog 🐶 Fallback function must be simple Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":2,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/MallorysMaliciousMisappropriation.sol"},"region":{"startColumn":2,"startLine":20}}}],"message":{"text":"Fallback function must be simple"},"ruleId":"no-complex-fallback"}
solhint: contracts/NftInvestmentFund.sol#L27
[solhint] reported by reviewdog 🐶 Rule is set with explicit type [var/s: uint] Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":2,"startLine":27}}}],"message":{"text":"Rule is set with explicit type [var/s: uint]"},"ruleId":"explicit-types"}
solhint: contracts/NftInvestmentFund.sol#L83
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":3,"startLine":83}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
solhint: contracts/NftInvestmentFund.sol#L95
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":4,"startLine":95}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
solhint: contracts/NftInvestmentFund.sol#L116
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":3,"startLine":116}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
solhint: contracts/NftInvestmentFund.sol#L152
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":3,"startLine":152}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
solhint: contracts/NftInvestmentFund.sol#L183
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":3,"startLine":183}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
solhint: contracts/NftInvestmentFund.sol#L187
[solhint] reported by reviewdog 🐶 GC: Use Custom Errors instead of require statements Raw Output: {"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":4,"uri":"file:///home/runner/work/sme4dd-eth-lab2/sme4dd-eth-lab2/contracts/NftInvestmentFund.sol"},"region":{"startColumn":3,"startLine":187}}}],"message":{"text":"GC: Use Custom Errors instead of require statements"},"ruleId":"gas-custom-errors"}
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "code-coverage-report". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: zgosalvez/github-actions-report-lcov@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Artifacts

Produced during runtime
Name Size
code-coverage-report Expired
193 KB