CI

Update PR.yml #33

Sign in to view logs

Triggered via push November 3, 2024 19:08

as3810t

pr-check

Status Success

Total duration 55s

Billable time 2m

Artifacts –

ci.yml

on: push

Annotations

1 error and 38 warnings

[eslint] .github/scripts/comment.js: .github/scripts/comment.js#L0

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): .github/scripts/comment.js

[solhint] contracts/MallorysMaliciousMisappropriation.sol#L20 <no-complex-fallback>: contracts/MallorysMaliciousMisappropriation.sol#L20

Fallback function must be simple

[solhint] contracts/NftInvestmentFund.sol#L27 <explicit-types>: contracts/NftInvestmentFund.sol#L27

Rule is set with explicit type [var/s: uint]

[solhint] contracts/NftInvestmentFund.sol#L83 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L83

GC: Use Custom Errors instead of require statements

[solhint] contracts/NftInvestmentFund.sol#L95 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L95

GC: Use Custom Errors instead of require statements

[solhint] contracts/NftInvestmentFund.sol#L116 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L116

GC: Use Custom Errors instead of require statements

[solhint] contracts/NftInvestmentFund.sol#L152 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L152

GC: Use Custom Errors instead of require statements

[solhint] contracts/NftInvestmentFund.sol#L183 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L183

GC: Use Custom Errors instead of require statements

[solhint] contracts/NftInvestmentFund.sol#L187 <gas-custom-errors>: contracts/NftInvestmentFund.sol#L187

GC: Use Custom Errors instead of require statements

[prettier] .github/scripts/comment.js: .github/scripts/comment.js#L0

File is not properly formatted.

[prettier] Code: Code#L0

style issues found in the above file. Run Prettier with --write to fix. File is not properly formatted.

[Slither] contracts/NftInvestmentFund.sol#L90-L102 <0-1-arbitrary-send-eth>: contracts/NftInvestmentFund.sol#L90

[NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102) sends eth to arbitrary user Dangerous calls: - [(sent,None) = address(msg.sender).call{value: withdrawAmount}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L94)

[Slither] contracts/NftInvestmentFund.sol#L109-L119 <0-1-arbitrary-send-eth>: contracts/NftInvestmentFund.sol#L109

[NftInvestmentFund.buyNFT(address,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L109-L119) sends eth to arbitrary user Dangerous calls: - [exchange.buyNFT{value: price}(listingId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L118)

[Slither] contracts/NftInvestmentFund.sol#L90-L102 <0-1-reentrancy-eth>: contracts/NftInvestmentFund.sol#L90

Reentrancy in [NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102): External calls: - [(sent,None) = address(msg.sender).call{value: withdrawAmount}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L94) State variables written after the call(s): - [balanceAtEnd -= withdrawAmount](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L98) [NftInvestmentFund.balanceAtEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L24) can be used in cross function reentrancies: - [NftInvestmentFund.balanceAtEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L24) - [NftInvestmentFund.closeFund()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L182-L192) - [NftInvestmentFund.constructor(string,string,uint256,uint256,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L40-L60) - [NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102) - [fundTokensAtEnd -= fundToken.balanceOf(msg.sender)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L99) [NftInvestmentFund.fundTokensAtEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L23) can be used in cross function reentrancies: - [NftInvestmentFund.closeFund()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L182-L192) - [NftInvestmentFund.fundTokensAtEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L23) - [NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102)

[Slither] contracts/NftExchange.sol#L63-L75 <0-1-reentrancy-eth>: contracts/NftExchange.sol#L63

Reentrancy in [NftExchange.buyNFT(uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L63-L75): External calls: - [(sent,None) = listing.seller.call{value: listing.price}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L68) - [IERC721(listing.nftContract).safeTransferFrom(address(this),msg.sender,listing.nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L70) External calls sending eth: - [(sent,None) = listing.seller.call{value: listing.price}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L68) State variables written after the call(s): - [listing.isSold = true](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L72) [NftExchange.listings](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L22) can be used in cross function reentrancies: - [NftExchange.buyNFT(uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L63-L75) - [NftExchange.listings](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L22) - [NftExchange.sellNFT(address,uint256,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L41-L57)

[Slither] contracts/MallorysMaliciousMisappropriation.sol#L20-L26 <1-1-divide-before-multiply>: contracts/MallorysMaliciousMisappropriation.sol#L20

[MallorysMaliciousMisappropriation.receive()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L20-L26) performs a multiplication on the result of a division: - [withdrawAmount = (nftInvestmentFund.balanceAtEnd() / nftInvestmentFund.fundTokensAtEnd()) * tokenCount](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L22)

[Slither] contracts/NftInvestmentFund.sol#L90-L102 <1-1-divide-before-multiply>: contracts/NftInvestmentFund.sol#L90

[NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102) performs a multiplication on the result of a division: - [withdrawAmount = (balanceAtEnd / fundTokensAtEnd) * fundToken.balanceOf(msg.sender)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L92)

[Slither] contracts/MallorysMaliciousMisappropriation.sol#L28-L36 <1-1-unused-return>: contracts/MallorysMaliciousMisappropriation.sol#L28

[MallorysMaliciousMisappropriation.attack()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L28-L36) ignores return value by [fundToken.approve(address(nftInvestmentFund),tokenCount)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L33)

[Slither] contracts/NftInvestmentFund.sol#L165-L179 <1-1-unused-return>: contracts/NftInvestmentFund.sol#L165

[NftInvestmentFund.registerNFTSales()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L165-L179) ignores return value by [(None,None,None,None,None,isSold) = exchange.listings(activeListing.listingId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L170)

[Slither] contracts/NftInvestmentFund.sol#L109-L119 <1-1-unused-return>: contracts/NftInvestmentFund.sol#L109

[NftInvestmentFund.buyNFT(address,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L109-L119) ignores return value by [(None,None,None,None,price,None) = exchange.listings(listingId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L115)

[Slither] contracts/NftInvestmentFund.sol#L165-L179 <2-1-calls-loop>: contracts/NftInvestmentFund.sol#L165

[NftInvestmentFund.registerNFTSales()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L165-L179) has external calls inside a loop: [(None,None,None,None,None,isSold) = exchange.listings(activeListing.listingId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L170)

[Slither] contracts/NftInvestmentFund.sol#L146-L162 <2-1-reentrancy-benign>: contracts/NftInvestmentFund.sol#L146

Reentrancy in [NftInvestmentFund.sellNFT(address,address,uint256,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L146-L162): External calls: - [IERC721(nftAddress).approve(nftExchangeAddress,nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L155) - [listingId = exchange.sellNFT(nftAddress,nftTokenId,price)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L157) State variables written after the call(s): - [activeListings.push(ActiveListing({nftExchangeAddress:nftExchangeAddress,listingId:listingId}))](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L159) - [_removeNFTToken(nftAddress,nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L161) - [ownedNftAddresses[j] = ownedNftAddresses[ownedNftAddresses.length - 1]](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L231) - [ownedNftAddresses.pop()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L232)

[Slither] contracts/NftExchange.sol#L41-L57 <2-1-reentrancy-benign>: contracts/NftExchange.sol#L41

Reentrancy in [NftExchange.sellNFT(address,uint256,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L41-L57): External calls: - [IERC721(nftContract).safeTransferFrom(msg.sender,address(this),nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L42) State variables written after the call(s): - [listingId = _nextListingId ++](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L44) - [listings[listingId] = Listing({listingId:listingId,nftContract:nftContract,nftTokenId:nftTokenId,seller:address(msg.sender),price:price,isSold:false})](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L46-L53)

[Slither] contracts/NftExchange.sol#L63-L75 <2-1-reentrancy-events>: contracts/NftExchange.sol#L63

Reentrancy in [NftExchange.buyNFT(uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L63-L75): External calls: - [(sent,None) = listing.seller.call{value: listing.price}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L68) - [IERC721(listing.nftContract).safeTransferFrom(address(this),msg.sender,listing.nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L70) External calls sending eth: - [(sent,None) = listing.seller.call{value: listing.price}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L68) Event emitted after the call(s): - [NftSold(listingId,msg.sender)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L74)

[Slither] contracts/NftExchange.sol#L41-L57 <2-1-reentrancy-events>: contracts/NftExchange.sol#L41

Reentrancy in [NftExchange.sellNFT(address,uint256,uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L41-L57): External calls: - [IERC721(nftContract).safeTransferFrom(msg.sender,address(this),nftTokenId)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L42) Event emitted after the call(s): - [NftOffered(listingId,nftContract,nftTokenId,msg.sender,price)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L55)

[Slither] contracts/NftInvestmentFund.sol#L165-L179 <3-1-costly-loop>: contracts/NftInvestmentFund.sol#L165

[NftInvestmentFund.registerNFTSales()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L165-L179) has costly operations inside a loop: - [activeListings.pop()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L174)

[Slither] contracts/FunnyNft.sol#L33-L35 <3-1-dead-code>: contracts/FunnyNft.sol#L33

[FunnyNft._increaseBalance(address,uint128)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/FunnyNft.sol#L33-L35) is never used and should be removed

[Slither] contracts/UniqueNft.sol#L27-L29 <3-1-dead-code>: contracts/UniqueNft.sol#L27

[UniqueNft._increaseBalance(address,uint128)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/UniqueNft.sol#L27-L29) is never used and should be removed

[Slither] contracts/FundToken.sol#L3 <3-0-solc-version>: contracts/FundToken.sol#L3

Version constraint ^0.8.22 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html) - VerbatimInvalidDeduplication. It is used by: - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/FundToken.sol#L3) - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/FunnyNft.sol#L3) - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L2) - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L3) - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L3) - [^0.8.22](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/UniqueNft.sol#L3)

[Slither] contracts/NftExchange.sol#L63-L75 <3-0-low-level-calls>: contracts/NftExchange.sol#L63

Low level call in [NftExchange.buyNFT(uint256)](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L63-L75): - [(sent,None) = listing.seller.call{value: listing.price}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftExchange.sol#L68)

[Slither] contracts/NftInvestmentFund.sol#L90-L102 <3-0-low-level-calls>: contracts/NftInvestmentFund.sol#L90

Low level call in [NftInvestmentFund.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L90-L102): - [(sent,None) = address(msg.sender).call{value: withdrawAmount}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L94)

[Slither] contracts/MallorysMaliciousMisappropriation.sol#L38-L41 <3-0-low-level-calls>: contracts/MallorysMaliciousMisappropriation.sol#L38

Low level call in [MallorysMaliciousMisappropriation.withdraw()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L38-L41): - [(sent,None) = address(msg.sender).call{value: address(this).balance}()](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L39)

[Slither] contracts/NftInvestmentFund.sol#L82 <3-0-naming-convention>: contracts/NftInvestmentFund.sol#L82

Parameter [NftInvestmentFund.invest(uint256)._tokenCount](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L82) is not in mixedCase

[Slither] contracts/NftInvestmentFund.sol#L18 <4-0-immutable-states>: contracts/NftInvestmentFund.sol#L18

[NftInvestmentFund.pricePerToken](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L18) should be immutable

[Slither] contracts/MallorysMaliciousMisappropriation.sol#L9 <4-0-immutable-states>: contracts/MallorysMaliciousMisappropriation.sol#L9

[MallorysMaliciousMisappropriation.nftInvestmentFund](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/MallorysMaliciousMisappropriation.sol#L9) should be immutable

[Slither] contracts/NftInvestmentFund.sol#L17 <4-0-immutable-states>: contracts/NftInvestmentFund.sol#L17

[NftInvestmentFund.fundToken](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L17) should be immutable

[Slither] contracts/NftInvestmentFund.sol#L21 <4-0-immutable-states>: contracts/NftInvestmentFund.sol#L21

[NftInvestmentFund.investmentEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L21) should be immutable

[Slither] contracts/NftInvestmentFund.sol#L20 <4-0-immutable-states>: contracts/NftInvestmentFund.sol#L20

[NftInvestmentFund.fundingEnd](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L20) should be immutable

[Slither] contracts/NftInvestmentFund.sol#L14 <4-0-immutable-states>: contracts/NftInvestmentFund.sol#L14

[NftInvestmentFund.fundManager](https://github.com/ftsrg/sme4dd-eth-lab2/blob/5a232811d7b67f020c1841b782ddf9d18189d79b/contracts/NftInvestmentFund.sol#L14) should be immutable