Skip to content

[fj-doc-mod-openpdf-ext] migrate junit4 to junit5 #363 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fj-doc-mod-openrtf-ext/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

import org.fugerit.java.doc.base.config.DocConfig;
import org.fugerit.java.doc.mod.openpdf.ext.helpers.OpenPpfDocHandler;
import org.junit.Assert;
import org.junit.Test;

import com.lowagie.text.pdf.BaseFont;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

public class TestDefaultDoc extends TestDocBase {
class TestDefaultDoc extends TestDocBase {

private static final String CUSTOM_FONT = "TitilliumWeb";

Expand All @@ -16,50 +16,50 @@ public class TestDefaultDoc extends TestDocBase {
private static final String DEFAULT_DOC_ALT = "default_doc_alt";

@Test
public void testOpenFailPDF() {
Assert.assertThrows( AssertionError.class , () -> this.testDocWorker( "default_doc_fail1" , DocConfig.TYPE_PDF ) );
void testOpenFailPDF() {
Assertions.assertThrows( AssertionError.class , () -> this.testDocWorker( "default_doc_fail1" , DocConfig.TYPE_PDF ) );
}

@Test
public void testCustomFont() {
void testCustomFont() {
BaseFont font = OpenPpfDocHandler.findFont( CUSTOM_FONT );
Assert.assertNotNull(font);
Assertions.assertNotNull(font);
}

@Test
public void testOpenPDF() {
void testOpenPDF() {
boolean ok = this.testDocWorker( DEFAULT_DOC , DocConfig.TYPE_PDF );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

@Test
public void testOpenHTML() {
void testOpenHTML() {
boolean ok = this.testDocWorker( DEFAULT_DOC , DocConfig.TYPE_HTML );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

@Test
public void testOpenRTF() {
void testOpenRTF() {
boolean ok = this.testDocWorker( DEFAULT_DOC , DocConfig.TYPE_RTF );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

@Test
public void testOpenAltPDF() {
void testOpenAltPDF() {
boolean ok = this.testDocWorker( DEFAULT_DOC_ALT , DocConfig.TYPE_PDF );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

@Test
public void testOpenAltHTML() {
void testOpenAltHTML() {
boolean ok = this.testDocWorker( DEFAULT_DOC_ALT , DocConfig.TYPE_HTML );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

@Test
public void testOpenAltRTF() {
void testOpenAltRTF() {
boolean ok = this.testDocWorker( DEFAULT_DOC_ALT , DocConfig.TYPE_RTF );
Assert.assertTrue(ok);
Assertions.assertTrue(ok);
}

}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package test.org.fugerit.java.doc.mod.openrtf.ext;

import static org.junit.Assert.fail;
import static org.junit.jupiter.api.Assertions.fail;

import java.io.File;
import java.io.FileOutputStream;
Expand All @@ -17,7 +17,7 @@
import org.fugerit.java.doc.freemarker.process.FreemarkerDocProcessConfigFacade;

@Slf4j
public class TestDocBase {
class TestDocBase {

private FreemarkerDocProcessConfig config = FreemarkerDocProcessConfigFacade.loadConfigSafe( "cl://fm-test-mod-openpdf-config.xml" );

Expand Down
Loading