Skip to content

[fj-doc-maven-plugin] when 'addDocFacade' is set to 'false' 'freemark… #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

[fj-doc-maven-plugin] when 'addDocFacade' is set to 'false' 'freemark… #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e7fc2
[fj-doc-maven-plugin] when 'addDocFacade' is set to 'false' 'freemark…
fugerit79 Apr 28, 2025
cfd0823
fix sonar issues #422
fugerit79 Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- quarkus-version set to 3.22.0 across all the modules <https://github.com/fugerit-org/fj-doc/pull/420>

### Fixed

- [fj-doc-maven-plugin] when 'addDocFacade' is set to 'false' 'freemarker-verify' execution gets an error <https://github.com/fugerit-org/fj-doc/pull/422>

## [8.13.8] - 2025-04-27

### Changed
Expand Down
4 changes: 2 additions & 2 deletions fj-doc-maven-plugin/src/main/java/org/fugerit/java/doc/project/facade/BasicVenusFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ protected static void addExtensionGradleList( File gradleFile, VenusContext cont
String gradleFileContent = FileIO.readString( gradleFile );
String fjDocVersion = context.getVersion();
if ( kts ) {
String valVersion = String.format( "val fjDocVersion = \"%s\"\n\ndependencies", context.getVersion() );
String valVersion = String.format( "val fjDocVersion = \"%s\"%n%ndependencies", context.getVersion() );
gradleFileContent = gradleFileContent.replaceFirst( "dependencies", valVersion );
fjDocVersion = "\\$fjDocVersion";
}
Expand Down Expand Up @@ -270,7 +270,7 @@ private static void addVerifyPluginExecution( Model model, String id, String tem

private static void addVerifyPlugin(VenusContext context, Model model ) throws IOException {
// addVerifyPlugin?
if ( context.isAddVerifyPlugin() ) {
if ( context.isAddVerifyPlugin() && context.isAddDocFacace() ) {
if ( context.isVerifyPluginNotAvailable() ) {
log.warn( "addVerifyPlugin skipped, version {} has been selected, minimum required version is : {}", context.getVersion(), VenusContext.VERSION_NA_VERIFY_PLUGIN );
} else {
Expand Down