coredump: Fix failure of executing gcore command due to memory write out of bounds #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out of bounds. executing gcore command fails with the following messages: crash> gcore -v 0 1 free(): invalid next size (normal) Aborted This is caused by the buffer size allocated for fill_files_note() is estimated as size = cprm->vma_count * 64, when filenames are generally long, it may lead to a write-out-of-bounds error, which occurs during free. The modification involves increasing the estimated size or calculating the total length of filenames in all VMAs, and then adding metadata information to obtain the size. Here, the latter approach is adopted.
|
Could you tell me how to reproduce this issue? Let the target process open a file with sufficiently lengthy a file name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executing gcore command fails with the following messages:
crash> gcore -v 0 1
free(): invalid next size (normal)
Aborted
This is caused by the buffer size allocated for fill_files_note() is estimated as size = cprm->vma_count * 64, when filenames are generally long, it may lead to a write-out-of-bounds error, which occurs during free.
The modification involves increasing the estimated size or calculating the total length of filenames in all VMAs, and then adding metadata information to obtain the size. Here, the latter approach is adopted.