Skip to content

fix markers rerender when click to open InfoWindow #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix markers rerender when click to open InfoWindow #310

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5077b3a
fix marker rerender
deadkff01 Jan 28, 2019
c71e463
feat(Marker): add verify marker position function
deadkff01 Sep 3, 2020
c152cee
feat(Marker): add verify marker position function
deadkff01 Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Marker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ export class Marker extends React.Component {

componentDidUpdate(prevProps) {
if ((this.props.map !== prevProps.map) ||
(this.props.position !== prevProps.position) ||
((this.props.position && prevProps.position)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most unreadable, please rather use a function such as 'arePositionsEqual' to simplify readability. thank you

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's been a long time, I'll see if this change still makes sense, if so, I'll make the change later.
Thanks for the feedback.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem still persists in the current version of the lib.

I solved your issue in the last commits.

? this.props.position.lat !== prevProps.position.lat || this.props.position.lng !== prevProps.position.lng
: this.props.position !== prevProps.position) ||
(this.props.icon !== prevProps.icon)) {
if (this.marker) {
this.marker.setMap(null);
Expand Down