You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently FumaDB can only be used once per database. This can be troublesome if I have multiple packages that use FumaDB that i want to host on my database, or if I am creating a managed service and want to use the same backend as self-host would then many customers can exist on the same database without having to do 1 customer per db which can be expensive.
I've mostly tested this with Postgres so not 100% sure on the compatibility with other DBs although i've tried to look into that, like with MongoDB we just need to add a prefix for example.
Also ran the formatter so some non-worked on files might have gotten added here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Looks good to me, I think it's a reasonable inconsistency to add, probably even better to have jsdoc on which database is supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently FumaDB can only be used once per database. This can be troublesome if I have multiple packages that use FumaDB that i want to host on my database, or if I am creating a managed service and want to use the same backend as self-host would then many customers can exist on the same database without having to do 1 customer per db which can be expensive.
I've mostly tested this with Postgres so not 100% sure on the compatibility with other DBs although i've tried to look into that, like with MongoDB we just need to add a prefix for example.
Also ran the formatter so some non-worked on files might have gotten added here.