fix: Updated join key in transform_new function in scale transformer #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/lags is none
added Value error to prevent running the backtest without features
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jhug12
changed the title
|
Ciao @jhug12! Thanks for the contribution. Will review asap. |
|
Ciao @jhug12, thanks again for the amazing work and spotting this bug. I have a fairly similar request like with your other PR: would you mind only keeping the commits related to the issue you raised? It'd be easier to review. Unfortunately that's a part of the codebase I am yet to become familiar with. |
baggiponte
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
What does this implement/fix? Explain your changes.
This pull request resolves an issue in the
transform_newfunction of the scale transformer module, where an error occurred during execution due to a mismatch in index columns during a join operation. Previously, the function attempted to join theXDataFrame with the_meanDataFrame on index columns ('time' and 'entity'), but_meancontained only the 'entity' column. The fix was implemented by adjusting the join keys to ensure they align correctly across both DataFrames, thus eliminating the key mismatch error.In addition to fixing the bug, this pull request updates the
transform_newfunction to match the format of thetransformandinvertfunctions.