Skip to content

Conversation

@AnniekStok
Copy link
Collaborator

Proposed Change

Add additional viewer models to view the orthogonal views (xz, yz) of the same data.
All interactive functionality (painting, selecting nodes, changing tool modes, undo/redo) should sync between the different viewers.

image

Checklist

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.

Further Comments

  • How to best extend/change this in order to also allow viewing different data (e.g. reference data) or the same data but at t+1? How can we best give the user more freedom about what to display in the different viewer models?
  • If the content of the different viewer models diverges from the main viewer, we will need separate Qt layer controls per layer per viewing model. Right now we only have the Qt layer controls of the layer on the main viewer, and sync the properties such as 'mode' and 'n_edit_dimensions'.
  • Currently the different viewer models are not dockable (though the window can optionally be hidden/resized). Trying to undock the entire widget kills the application for unclear reasons if it contains any viewer models :(

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.66%. Comparing base (6d17332) to head (e5ba454).

Files with missing lines Patch % Lines
...k_data_views/views/view_3d/multiple_view_widget.py 73.68% 55 Missing ⚠️
...inn/track_data_views/views/view_3d/cross_widget.py 31.42% 48 Missing ⚠️
finn/track_data_views/views/layers/track_labels.py 16.66% 30 Missing ⚠️
finn/track_data_views/views/layers/track_points.py 14.70% 29 Missing ⚠️
...track_data_views/views/view_3d/orthogonal_views.py 42.85% 8 Missing ⚠️
finn/track_application_menus/menu_widget.py 25.00% 3 Missing ⚠️
...rack_data_views/views/layers/tracks_layer_group.py 0.00% 2 Missing ⚠️
finn/track_application_menus/main_app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   88.81%   88.66%   -0.16%     
==========================================
  Files         656      660       +4     
  Lines       60692    61191     +499     
==========================================
+ Hits        53901    54252     +351     
- Misses       6791     6939     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants