Skip to content

branching the preview of images attached to a Wiki page due to a change of core API in KB 1.2.38#112

Merged
lastlink merged 3 commits intofunktechno:devfrom
imfx77:dev
May 11, 2025
Merged

branching the preview of images attached to a Wiki page due to a change of core API in KB 1.2.38#112
lastlink merged 3 commits intofunktechno:devfrom
imfx77:dev

Conversation

@imfx77
Copy link
Contributor

@imfx77 imfx77 commented May 10, 2025

All Submissions:

  • Notify authors: @lastlink
  • Have you updated the ChangeLog with your proposed changes?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • pr update to master branch
    • Have you updated the getPluginVersion() in Plugin.php and Makefile version appropriately?

New Feature Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Description

Fixes #108.

Changes proposed in this pull request:

  • branching the preview of images attached to a Wiki page due to a change of core API in KB 1.2.38
  • automating the makefile to obtain plugin name and version from Plugin.php (no need to manually sync them anymore!!!)
  • excluding unnecessary files and folders from the plugin ZIP bundle and setting compression to max level 9
  • fixes to the PR template

imfx77 added 3 commits May 10, 2025 22:50
* automating the makefile to obtain plugin name and version from Plugin.php (no need to manually sync them anymore!!!)
* excluding unnecessary files and folders from the plugin ZIP bundle and setting compression to max level 9
@lastlink
Copy link
Contributor

@imfx77 looks good. You can merge. Did you want to cut a new release or have me do it?

@imfx77
Copy link
Contributor Author

imfx77 commented May 10, 2025

@imfx77 looks good. You can merge. Did you want to cut a new release or have me do it?

I don't think I have the proper access for this repo to merge PRs or issue new releases.
And probably it's better that I don't have - there should be a single authority per repo that is allowed to do such things so to avoid making a mess 😉

@lastlink lastlink merged commit 0ca2df3 into funktechno:dev May 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No attached files and images after upgrade to 0.4.0 from 0.3.8

2 participants