Skip to content

Fix: vtk codec to read ascii polydata and support v1.0 - #4

Merged
skoudoro merged 1 commit into
fury-gl:masterfrom
ganimtron-10:vtk-fixes
Jun 16, 2026
Merged

Fix: vtk codec to read ascii polydata and support v1.0#4
skoudoro merged 1 commit into
fury-gl:masterfrom
ganimtron-10:vtk-fixes

Conversation

@ganimtron-10

Copy link
Copy Markdown
Collaborator

No description provided.

@skoudoro

skoudoro commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Thank for this. Hard to see the changes. we need to merge the other PR's and you need to rebase this one

@ganimtron-10 ganimtron-10 changed the title Fix: vtk codec to support v1.0 Fix: vtk codec to read ascii polydata and support v1.0 Jun 7, 2026
@ganimtron-10
ganimtron-10 requested a review from skoudoro June 9, 2026 18:57
@ganimtron-10

Copy link
Copy Markdown
Collaborator Author

@skoudoro would need your feedback on how do we handle the point, line and triangles data from the vtk file as it can have any combination of those. This is still a working draft just wanted to make sure I am in right direction.

@skoudoro
skoudoro marked this pull request as ready for review June 15, 2026 18:35
@skoudoro

Copy link
Copy Markdown
Collaborator

Hi @ganimtron-10, I tried to read multiple files and it fails:
vtk.vtk , track1.binary.vtk, matrix.vtk

I get multiple variation of this error:

polyxios.exceptions.CodecError: VTK codec supports only DATASET UNSTRUCTURED_GRID, got: 'DATASET STRUCTURED_POINTS'

Do you encounter this also ?

@ganimtron-10

Copy link
Copy Markdown
Collaborator Author

Hi @skoudoro, Yes I too encounter these errors as binary and structured grid parsing is not yet there in this code. I am working on adding that.

@skoudoro

Copy link
Copy Markdown
Collaborator

ok, I was also going to work on that now. Did you start ?

merging

@skoudoro
skoudoro merged commit 916b5b5 into fury-gl:master Jun 16, 2026
12 checks passed
@ganimtron-10

Copy link
Copy Markdown
Collaborator Author

I had started it but wasnt able to complete. Here's the branch: https://github.com/ganimtron-10/polyxios/tree/polyxios-data-tester
It might take me a little longer to complete this as I am stuck between few other things.

skoudoro added a commit to skoudoro/polyxios that referenced this pull request Aug 31, 2026
Fix: vtk codec to read ascii polydata and support v1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants