Repository navigation
chore(deps): bump fast-uri past its advisories in the demo lockfile - #255
Merged
Merged
Conversation
#254 raised the root override for fast-uri but left the demo's at <3.1.7, so the demo still resolved 3.1.8 under three-text-geometry (file:..) -> ajv. `pnpm audit` in demo/ does not descend into the file: dependency, which is why it reported nothing. GHSA-w74x-v6f9-j3xg, GHSA-wjr9-j795-jxcr, GHSA-xhq7-xmqj-769h, GHSA-333x-w4r6-6crp
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #254. It raised the root
fast-urioverride to^3.1.9but left the demo's at<3.1.7, sodemo/pnpm-lock.yamlstill resolved 3.1.8 throughthree-text-geometry(file:..) →ajv. Dependabot raised four alerts for it once #254 reachedmain.pnpm auditindemo/reported no vulnerabilities before this change: it does not descend into thefile:dependency. The version below is checked withpnpm whyinstead.Advisories: GHSA-w74x-v6f9-j3xg, GHSA-wjr9-j795-jxcr, GHSA-xhq7-xmqj-769h, GHSA-333x-w4r6-6crp
Verification
pnpm why fast-uriindemo/:three-text-geometry→ajv→fast-uri 3.1.9demo/builds;pnpm e2e9 passedFixes FUT-369