-
Notifications
You must be signed in to change notification settings - Fork 71
Add welsh emoji lookups #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add welsh emoji lookups #1525
Conversation
Where were the translations sourced from? The jsondlgz is generated automatically from CLDR so it probably shouldn't be modified directly as it would make future updates more complicated. There was also already a #cy section in the json from the CLDR, is there a reason to replace it with a different one? |
Thanks, abb128!
Many translations were missing for the original #cy section (e.g. some
emojis weren't searchable, and / or only searchable with a few keywords or
English. Also some important Welsh-context emojis were missing (e.g. Welsh
flag 🏴 - note this is also missing from #en).
It sounds like I should try and make those changes upstream in this case -
presumably you're pulling from here?
https://cldr.unicode.org/#translations-and-other-language-data
…On Sat, Aug 23, 2025, 6:38 PM abb128 ***@***.***> wrote:
*abb128* left a comment (futo-org/android-keyboard#1525)
<#1525 (comment)>
Where were the translations sourced from?
The jsondlgz is generated automatically from CLDR so it probably shouldn't
be modified directly as it would make future updates more complicated.
There was also already a #cy section in the json from the CLDR, is there a
reason to replace it with a different one?
—
Reply to this email directly, view it on GitHub
<#1525 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEXH72MYCOMDBJGE6XKHT3PAR73AVCNFSM6AAAAACETNB3TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJWGU3TINJWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Oh, and the translations were created using a script with
google-cloud-translate, and then hand vetted by myself (sampled). Google
translate is very good for en<>cy due to the large corpus of en<>cy
available from the Welsh government (Welsh ML is something I work on also)
On Sat, Aug 23, 2025, 7:52 PM Patrick Robertson ***@***.***>
wrote:
… Thanks, abb128!
Many translations were missing for the original #cy section (e.g. some
emojis weren't searchable, and / or only searchable with a few keywords or
English. Also some important Welsh-context emojis were missing (e.g. Welsh
flag 🏴 - note this is also missing from #en).
It sounds like I should try and make those changes upstream in this case -
presumably you're pulling from here?
https://cldr.unicode.org/#translations-and-other-language-data
On Sat, Aug 23, 2025, 6:38 PM abb128 ***@***.***> wrote:
> *abb128* left a comment (futo-org/android-keyboard#1525)
> <#1525 (comment)>
>
> Where were the translations sourced from?
>
> The jsondlgz is generated automatically from CLDR so it probably
> shouldn't be modified directly as it would make future updates more
> complicated. There was also already a #cy section in the json from the
> CLDR, is there a reason to replace it with a different one?
>
> —
> Reply to this email directly, view it on GitHub
> <#1525 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABEXH72MYCOMDBJGE6XKHT3PAR73AVCNFSM6AAAAACETNB3TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJWGU3TINJWGQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
I see, yes CLDR would be upstream. I'm not familiar with the CLDR contribution process but you can try contributing there (let me know if you have any luck). I can see about including the json as an override for Welsh in the meantime |
Thanks, yeah I've just had a quick look at the unicode contribution process
and it seems... Complicated. Will let you know how I get on, but an
override might be useful initially!
…On Sat, Aug 23, 2025, 8:03 PM abb128 ***@***.***> wrote:
*abb128* left a comment (futo-org/android-keyboard#1525)
<#1525 (comment)>
I see, yes CLDR would be upstream. I'm not familiar with the CLDR
contribution process but you can try contributing there (let me know if you
have any luck). I can see about including the json as an override for Welsh
in the meantime
—
Reply to this email directly, view it on GitHub
<#1525 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEXH2JBV3F522NXYX3XIT3PA4AXAVCNFSM6AAAAACETNB3TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJWGY2DQNZVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This change takes the existing
emoji_i18n.jsondlgz
and adds a#cy
section at the end, with lookups in Welsh for emojis. Here are some screenshots of it in action:I'm attaching the translated json file for the Welsh, in case it's needed in the future for future builds.
cy_emojis.json