Skip to content

Android & KMP danger tokens #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejsemancik merged 2 commits into from
Nov 12, 2025
Merged

Android & KMP danger tokens #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d15b205
ci: Allow configurable GitHub token for Danger
matejsemancik Nov 12, 2025
17fe211
fix(android-check): Ensure Danger action uses explicit GitHub token
matejsemancik Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/actions/android-check/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ inputs:
test_gradle_task:
description: "A Gradle task(s) for executing unit tests, for example `testReleaseUnitTest` or `testDevEnterpriseUnitTest`"
required: true
github_token_danger:
description: "GitHub token for Danger. Must have permissions to read and write issues and pull requests."
required: false

runs:
using: "composite"
Expand All @@ -27,4 +30,4 @@ runs:
danger_file: 'Dangerfile'
danger_id: 'danger-pr'
env:
DANGER_GITHUB_API_TOKEN: ${{ github.token }}
DANGER_GITHUB_API_TOKEN: ${{ inputs.github_token_danger || github.token }}
Copy link
Contributor

@ssestak ssestak Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken if you not pass token to Danger it will still use the "default one". It have build-in fallback logic to use github.token.

Copy link
Member Author

@matejsemancik matejsemancik Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I pass empty string? (I believe that non-existent input gets resolved into empty string)

Copy link
Member Author

@matejsemancik matejsemancik Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well nvm let's try it that way

4 changes: 4 additions & 0 deletions .github/workflows/android-cloud-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ on:
GRADLE_CACHE_ENCRYPTION_KEY:
required: false
description: "Configuration cache encryption key"
GITHUB_TOKEN_DANGER:
required: false
description: "GitHub token for Danger. Must have permissions to read and write issues and pull requests."

jobs:
test:
Expand All @@ -68,3 +71,4 @@ jobs:
with:
lint_gradle_task: ${{ inputs.LINT_GRADLE_TASKS }}
test_gradle_task: ${{ inputs.TEST_GRADLE_TASKS }}
github_token_danger: ${{ secrets.GITHUB_TOKEN_DANGER }}
5 changes: 4 additions & 1 deletion .github/workflows/ios-kmp-selfhosted-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ on:
GRADLE_CACHE_ENCRYPTION_KEY:
required: false
description: "Configuration cache encryption key"
GITHUB_TOKEN_DANGER:
required: false
description: "GitHub token for Danger. Must have permissions to read and write issues and pull requests."

jobs:
test:
Expand Down Expand Up @@ -82,7 +85,7 @@ jobs:
- name: Fastlane Test
uses: futuredapp/.github/.github/actions/ios-fastlane-test@main
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN_DANGER }}
custom_values: ${{ inputs.custom_values }}
ios_root_path: iosApp
custom_build_path: ${{ inputs.custom_build_path }}