NRGBA -> RGBA for text rasterize#6253
Merged
Merged
Conversation
|
coverage: 60.436% (+0.01%) from 60.426% — redawl:rgba_strings into fyne-io:develop |
dweymouth
approved these changes
Apr 6, 2026
dweymouth
left a comment
dweymouth
left a comment
Contributor
There was a problem hiding this comment.
There is also a fast path on imgToTexture for RGBA, but NRGBA necessitates conversion to RGBA before uploading as a GPU texture, so switching to RGBA as the source image here is definitely the right move irrespective of the golang/x/image fast path.
andydotxyz
pushed a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take advantage of the RGBA fast path in golang.org/x/image for text rasterization.
Helps with the stuttering in #6233