Add ClearSelection method to Entry and Label#6379
Open
uttam12331 wants to merge 2 commits into
Open
Conversation
andydotxyz
requested changes
Jun 27, 2026
andydotxyz
left a comment
Member
There was a problem hiding this comment.
Thanks for this, but since needs to target the next release as we don't add API in point releases.
The feature window is missed on 2.8 so please update to 2.9
Author
|
Thanks for the review! Updated the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6375.
Adds a
ClearSelection()method towidget.Entryandwidget.Labelso callers can programmatically cancel an active text selection without needing knowledge of the internal selection state (the workaround previously was re-callingSetTextwith the same text).Entry.ClearSelection()andLabel.ClearSelection()clear an active selection and refresh; both are no-ops when nothing is selected (or, for Label, when it isn'tSelectable).TestEntry_ClearSelectionandTestLabel_ClearSelectioncovering the selection-then-clear path and the no-op case.Verified locally with
go test ./widget/(both tests pass),gofmt, andgo vet ./widget/.