Skip to content

[qBittorrent] Bump bjw-s common chart version to 3.7.x #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincentkelleher
Copy link

Hi 👋

I noticed that the BJW-S common Helm chart dependency was a bit out-of-date while trying to deploy qBittorrent with an NFS mount point described as an existing PersistentVolumeClaim (useful to add some NFS mount options).

This pull request proposes an update of this chart dependency with a few changes as it's a major version bump such as:

  • a new values.yaml organization
  • a different way of defining the dependency's version to allow for minor and patch updates to be pulled automatically during updates
  • the deletion of the NOTES.txt file as the new BJW-S common chart doesn't seem to support notes generation

I've tested everything with a basic values.yaml file I wrote for my home lab and with the helm template command, everything seems to work fine ✅

@gabe565
Copy link
Owner

gabe565 commented Apr 20, 2025

@vincentkelleher Hey! Thanks for opening this. I'll do some testing and merge this PR soon. I've been slightly hesitant to update all of these charts since v2 and v3 have major breaking changes, and ever since bjw-s released his app-template chart, I've been using that one in my personal infra anyways. That being said, I'm not against updating. I just feel bad making everyone redo their values 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants