Skip to content

Optimizations (Redone because previous PR had conflicts)#215

Open
TommiPrami wants to merge 3 commits intogabr42:masterfrom
TommiPrami:FixInsight
Open

Optimizations (Redone because previous PR had conflicts)#215
TommiPrami wants to merge 3 commits intogabr42:masterfrom
TommiPrami:FixInsight

Conversation

@TommiPrami
Copy link
Copy Markdown
Contributor

  • inlined routines must be implemented before it used. Delphi is single pass compiler and inlining is impossible if not done so.
  • Unmodified string parameters marked as const, should be clearly fasted this way, Affect to real word usage might be negligible

 - inlined routines must be implemented before it used. Delphi is single pass compiler and inlining is impossible if not done so.
 - Unmodified string parameters marked as const, should be clearly fasted this way, Affect to real word usage might be negligible
@bito-code-review
Copy link
Copy Markdown

Bito Review Skipped - Source Branch Not Found

Bito didn't review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

@TommiPrami
Copy link
Copy Markdown
Contributor Author

Any plans to incorporate this pull request?

I've been running these changes for few months at least. Tough my usage is not super comprehensive, but something.

Some are no brainers, like inline marked routines that can't be inlined, because code is in wrong place for the inlining. And some unmonifieds string parameters are not passed as const.

Byt I am not the boss, though would be nice to know if this will be merged or not. So I will not waste my time to make enhancements to the codebase if those will not match coding style (or some other reason) of repo owner .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant