feat(i18n): add internationalization support with English and Portugu…#23
Draft
RafaelLimaC wants to merge 17 commits intomainfrom
Draft
feat(i18n): add internationalization support with English and Portugu…#23RafaelLimaC wants to merge 17 commits intomainfrom
RafaelLimaC wants to merge 17 commits intomainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- package.json: Language not supported
- src/i18n/locales/en-us.json: Language not supported
- src/i18n/locales/pt-br.json: Language not supported
Comments suppressed due to low confidence (1)
src/components/Header/Header.tsx:27
- Direct use of the global 'location' object may cause issues in certain environments. Consider using the 'useLocation' hook from react-router for improved integration and reliability.
location.pathname === nav.redirect || location.hash === nav.redirect
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- package.json: Language not supported
- src/i18n/locales/en-us.json: Language not supported
- src/i18n/locales/pt-br.json: Language not supported
Comments suppressed due to low confidence (1)
src/components/Header/Header.tsx:8
- [nitpick] Consider renaming the interface from 'NavItems' to 'NavItem' to better represent a single navigation item.
interface NavItems {
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- package.json: Language not supported
- src/i18n/locales/en-us.json: Language not supported
- src/i18n/locales/pt-br.json: Language not supported
Comments suppressed due to low confidence (1)
src/components/Header/Header.tsx:8
- [nitpick] Consider renaming the interface 'NavItems' to 'NavItem' since it represents a single navigation item rather than a collection.
interface NavItems {
Frompaje
reviewed
Apr 10, 2025
zoldyzdk
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- package.json: Language not supported
- src/i18n/locales/en-us.json: Language not supported
- src/i18n/locales/pt-br.json: Language not supported
Comments suppressed due to low confidence (1)
src/components/Header/Header.tsx:32
- Initializing the active navigation state only on component mount may cause inconsistencies if the route changes without a click event. Consider deriving the active state directly from router.pathname or using a useEffect hook to update the state when the route changes.
const [activeItem, setActiveItem] = useState(() => getActiveNavItem(navItems, router.pathname));
There was a problem hiding this comment.
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (3)
- package.json: Language not supported
- src/i18n/locales/en-us.json: Language not supported
- src/i18n/locales/pt-br.json: Language not supported
Comments suppressed due to low confidence (1)
src/i18n/index.ts:26
- Directly accessing localStorage and navigator may cause runtime errors in non-browser environments. Consider adding a check to ensure these are available before usage.
lng: localStorage.getItem('@i18n') || getSupportedLocale(navigator.language),
hxsggsz
reviewed
Apr 12, 2025
Contributor
Author
|
i18n implementado seguindo o exemplo do next: |
zoldyzdk
requested changes
Apr 15, 2025
GabrielTrindadeC
approved these changes
Apr 15, 2025
…ese translations feat(Header): implement Header component with navigation and routing chore: update package dependencies for i18next and react-i18next
…layout and header components
…d header component
…cale switching functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14
feat(Header): implement Header component with navigation and routing
chore: update package dependencies for i18next and react-i18next
Issue ticket number and link
Describe your changes
Visual
Checklist before requesting a review