Open
Conversation
mohosy
reviewed
Feb 27, 2026
mohosy
left a comment
mohosy
left a comment
There was a problem hiding this comment.
Review note on 'fix: fix isSafePath regex': changedFiles=2, additions=3, deletions=1.\n\nPlease verify tests cover boundary/error cases for modified components and confirm no regressions in adjacent flows.
Contributor
Author
|
I added two relevant test cases that cover the change. All existing tests pass as well, so there should be no regressions. Could you clarify which boundary or error cases you think might be missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
\0with0to accept.0and reject paths containing null bytes.