Flatten unregistered claims #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaku-sei
commented
Jul 31, 2020
| <> (Options.jwtid := jti) | ||
| <> (Options.subject := sub) | ||
| <> (Options.keyid := kid) | ||
| <> (Options.header := signHeaderOptions) |
Owner
Author
There was a problem hiding this comment.
Cleaned up the options as well
gaku-sei
commented
Jul 31, 2020
| verify (Secret secret) s = (note (singleton "Couldn't verify token") $ runFn4 _verify Just Nothing s secret) >>= foreignToToken | ||
|
|
||
| verify' :: Secret -> String -> Either (NonEmptyList String) (Token () Unverified) | ||
| verify' = verify |
Owner
Author
There was a problem hiding this comment.
decode' and verify' are useful when dealing with token that have no unregistered claims, or when the unregistered claims don't matter.
gaku-sei
force-pushed
the
flatten-unregistered
branch
from
a8415d4 to
eaa5333
Compare
gaku-sei
commented
Jul 31, 2020
| exports._decode = function decode(just, nothing, token) { | ||
| const registeredClaimsKeys = ["iss", "sub", "aud", "exp", "nbf", "iat", "jti"]; | ||
|
|
||
| // TODO: Remove this when https://github.com/erikd/language-javascript/pull/118 is merged |
Owner
Author
There was a problem hiding this comment.
Hopefully merged soon, the partitionClaims function is unsafe, dirty, and verbose 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unregistered claims will now get inserted at the top level, and not under the "unregistered" attribute anymore. I had to handle the flatten/normalize logic in JS, and since object spread is not yet supported in PureScript's JavaScript (quintenkasteel/language-javascript#118) the code is a bit verbose. Once the above pr is merged, the code should be way cleaner.