-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xcm benchmarking #995
base: master
Are you sure you want to change the base?
Conversation
… teleport within hydra
Crate versions that have been updated:
Runtime version has been increased. |
How did you check the weights are lower than b4? Can you drop old bench results somewhere so we can confirm? |
fun: Fungible(ExistentialDeposit::get()), | ||
} | ||
} | ||
} | ||
|
||
use primitives::constants::currency::UNITS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably split this to separate file as it's getting crowded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you remember, the last time when we tried to put the runtime apis into a separate file, we had a weird error on prod, so maybe it is just better to leave it in lib.rs...
Just did some testing. Not all extrinsic became cheaper. Here is the old weight for all xcm extrinsic:
This was used as an "overestimate". It seems it was not that good overestimate. Here are the xcm extrinsics that became more expensive after the current rebenchmarking:
And here are the ones that became cheaper:
Based on this result, it seems we gotta wait for |
#989
TODO: