Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

@eamansour
Copy link
Contributor

@eamansour eamansour commented Aug 21, 2024

Why?

See galasa-dev/projectmanagement#1921

Changes

  • Instead of iterating through page numbers, runs get now uses the cursor provided in responses from /ras/runs to go through pages of run results

@galasa-team
Copy link

Build successful

@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 9bd3a62 to 6bab24c Compare August 22, 2024 08:34
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 6bab24c to 18310fc Compare August 22, 2024 08:35
@eamansour eamansour requested a review from techcobweb August 22, 2024 08:52
Signed-off-by: Eamonn Mansour <[email protected]>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-qx7nh for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-k4575 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-q2dl7 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 07f55ab to 782c97a Compare August 22, 2024 11:53
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-7kdth for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-fxxtc for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from aebf3aa to be5133a Compare August 22, 2024 15:09
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-b7mrx for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-rz742 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 0350754 to 354b1e8 Compare August 22, 2024 15:55
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-bdk64 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-2j9nh for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-2cglq for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 806d633 to 2efff1f Compare August 27, 2024 14:09
@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 06a819d into main Aug 27, 2024
@eamansour eamansour deleted the iss1921-runs-get-performance branch August 27, 2024 14:28
aashir21 pushed a commit that referenced this pull request Sep 18, 2024
* Use cursor-based pagination when getting runs from the API server

Signed-off-by: Eamonn Mansour <[email protected]>

* Remove includeCursor query parameter

Signed-off-by: Eamonn Mansour <[email protected]>

* Swap cursor condition order

Signed-off-by: Eamonn Mansour <[email protected]>

* Turn on includeCursor parameter

Signed-off-by: Eamonn Mansour <[email protected]>

* Remove log statement

Signed-off-by: Eamonn Mansour <[email protected]>

* Use 'from:desc' as the default sort for runs get

Signed-off-by: Eamonn Mansour <[email protected]>

---------

Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Aashir Siddiqui <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants