Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

@eamansour
Copy link
Contributor

@eamansour eamansour commented Mar 26, 2025

Why?

See galasa-dev/projectmanagement#2067

Note: Builds for this PR will fail until the openapi changes in galasa-dev/galasa#238 are delivered.

Changes

  • Added galasactl monitors set command with a --is-enabled flag to enable/disable a monitor with the given name in a Galasa service

@techcobweb
Copy link
Contributor

I'm also wondering whether we should use syntax like this:
galasactl monitors set --name xxxx --isEnabled true or not, as we could add more flags to that without needing extra commands.

Not sure it's worth it, given enabling and disabling is the prime requirement, and if we support galasactl resources apply -f eventually, you can set all the other things.

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour changed the title Add monitors enable and monitors disable commands Add monitors set command Mar 27, 2025
@eamansour
Copy link
Contributor Author

eamansour commented Mar 27, 2025

I'm also wondering whether we should use syntax like this: galasactl monitors set --name xxxx --isEnabled true or not, as we could add more flags to that without needing extra commands.

Not sure it's worth it, given enabling and disabling is the prime requirement, and if we support galasactl resources apply -f eventually, you can set all the other things.

As discussed, monitors enable and monitors disable have been replaced with monitors set --name xxx --is-enabled true in fefd279

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@eamansour eamansour merged commit fc876ed into main Mar 28, 2025
6 checks passed
@eamansour eamansour deleted the em-2067-monitors-enable-disable branch March 28, 2025 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants