This repository was archived by the owner on Jun 10, 2025. It is now read-only.
Minor updates #876
Merged
Minor updates #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaroMac
reviewed
May 11, 2025
Contributor
There was a problem hiding this comment.
I am a bit confused by this sentence "Managers implementing anyReasonTestMethodShouldBeIgnored will not be called to see whether the manager wants to veto the execution of @Before or @After methods separately to the test method they surround."
Contributor
Author
There was a problem hiding this comment.
How about this instead?
Managers implementing
anyReasonTestMethodShouldBeIgnoredare no longer asked whether the test method should be ignored before running the@Beforeand@Aftermethods. If the test method is ignored, then the@Beforeand@Aftermethods are also ignored.
Tidy up a few things following 0.41.0 review comments Signed-off-by: James Taylor <[email protected]>
jt-nti
added a commit
to jt-nti/galasa
that referenced
this pull request
Jun 10, 2025
Tidy up a few things following 0.41.0 review comments Supersedes galasa-dev-archives/galasa.dev#876 Signed-off-by: James Taylor <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up a few things following 0.41.0 review comments