Skip to content

Iss2190 - Enhance/fix errors in Test Simbank #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jadecarino merged 2 commits into from
May 27, 2025
Merged

Iss2190 - Enhance/fix errors in Test Simbank #190

jadecarino merged 2 commits into from
May 27, 2025

Conversation

@jadecarino
Copy link
Member

@jadecarino jadecarino commented May 27, 2025

Why?

  1. Skip steps about combining/reporting the test results into Slack channel if being run on a fork.
  2. Fix incorrect path to the test report.
  3. Check in the credentials.properties file as its a set of dummy credentials it's not dangerous. Updated .secrets.baseline file containing this change.

jadecarino added 2 commits May 27, 2025 14:03
@jadecarino
Check in credentials.properties file as they only contain dummy creds…
6ddf0b1 
…, and fix incorrect path to the tests.json report

Signed-off-by: Jade Carino <[email protected]>
@jadecarino
Update .secrets.baseline now that the Simbank credentials.properties …
d68c6ad 
…have been checked in, they are not real secrets

Signed-off-by: Jade Carino <[email protected]>
@jadecarino jadecarino merged commit 26626e1 into galasa-dev:main May 27, 2025
4 checks passed
@jadecarino jadecarino deleted the iss2190-fix-errors-in-test-simbank branch May 27, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jadecarino