fix: default query options should be relative to now instead of specific times #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eToNow boolean Signed-off-by: Tasneemmhammed0 <[email protected]>
Signed-off-by: Tasneemmhammed0 <[email protected]>
Signed-off-by: Tasneemmhammed0 <[email protected]>
Signed-off-by: Tasneemmhammed0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Fixes #2433.
Changes
When navigating to a saved query or when
isRelativeToNowchanges via URL parameters, theTimeFrameradio button selection was not syncing with the URL state, causing a mismatch between the UI and the actual query.This is now fixed: loading a saved query correctly reflects Now or Specific Time based on
isRelativeToNow. If the URL includesduration,isRelativeToNowis set totrueand the Now option is selected (this was already the default behavior but was not previously synchronized with the UI).Important
Currently, only
durationis persisted in the URL. When present, Now is always selected; otherwise,from/toare used. This prevents distinguishing all four time options (e.g. Specific from date → Now).Addressing this properly would require introducing a new URL parameter to represent the selected time mode, which is better handled in a separate PR due to the scope of changes.