Add a test for the ranking function using locations of the destinations #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2520f94.
Scheduling tags must be a yaml list
nuwang
reviewed
Nov 22, 2023
Member
nuwang
left a comment
nuwang
left a comment
There was a problem hiding this comment.
Since the location related tests are fairly standalone, could you move it into its own folder under tests? That'll make them easier to find since they are grouped together.
This reverts commit 747a2b4. This change has been addressed and merged with main from a different branch
…et_dataset_attributes. And uses the requests library rather than httpx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test tries to match object stores to their closest destinations using latitude and longitude.