Skip to content

fix(button-group): use "horizontal" instead of falsy "" #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 1 commit into from
Feb 14, 2025
Merged

fix(button-group): use "horizontal" instead of falsy "" #3393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/block/button-group/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const TOOLBAR_ALIGN_OPTIONS = ALIGN_OPTIONS.map( control => {
const ALIGNMENT_CONTROLS_DESKTOP = [
{
title: __( 'Horizontal', i18n ),
value: '',
value: 'horizontal',
},
{
title: __( 'Vertical', i18n ),
Expand Down Expand Up @@ -134,7 +134,7 @@ const Edit = props => {
] )

let contentAlignControls = null
if ( attributes.buttonAlign === '' ) {
if ( attributes.buttonAlign === 'horizontal' ) {
contentAlignControls = ALIGN_OPTIONS
}
if ( deviceType === 'Tablet' || deviceType === 'Mobile' ) {
Expand Down
5 changes: 3 additions & 2 deletions src/block/button-group/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ blockStyles.addBlockStyles( 'buttonAlign', [ {
valuePreCallback: value => {
if ( value === 'vertical' ) {
return 'column'
} else if ( value === 'horizontal' ) {
return 'row'
}

return 'row'
return value
},
}, {
renderIn: 'edit',
Expand Down
Loading