Skip to content

Fix (carousel block): display correct layout and remove frontend console errors #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Oct 10, 2025
Merged

Fix (carousel block): display correct layout and remove frontend console errors #3619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a60ee
fix console errors when not using infinite scrolling
kaeizen Oct 8, 2025
483ab84
fix carousel layout
kaeizen Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/block/carousel/frontend-carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,9 @@ class _StackableCarousel {
onWheel = e => {
const sliderElScrollLeft = this.sliderEl.scrollLeft
const lastSlideOffset = this.slideEls[ this.slideEls.length - 1 ].offsetLeft
const firstCloneOffset = this.clones[ 0 ].offsetLeft
const slidesOffset = this.slideEls.map( slide => slide.offsetLeft )
const clonesOffset = this.clones.map( slide => slide.offsetLeft )
const firstCloneOffset = this.infiniteScroll && this.clones.length ? this.clones[ 0 ].offsetLeft : 0
const clonesOffset = this.infiniteScroll && this.clones.length ? this.clones.map( slide => slide.offsetLeft ) : []
if ( this.type === 'fade' ) {
if ( this.wheelTimeout ) {
return
Expand Down Expand Up @@ -549,7 +549,7 @@ class _StackableCarousel {
let dx = e.clientX - this.initialClientX
const sliderElScrollLeft = this.sliderEl.scrollLeft
const lastSlideOffsetLeft = this.slideEls[ this.slideEls.length - 1 ].offsetLeft
const firstCloneOffsetLeft = this.clones[ 0 ].offsetLeft
const firstCloneOffsetLeft = this.infiniteScroll && this.clones.length ? this.clones[ 0 ].offsetLeft : 0

if ( this.type === 'slide' ) {
if ( this.infiniteScroll && sliderElScrollLeft === 0 && dx > 0 ) {
Expand Down
2 changes: 2 additions & 0 deletions src/styles/block.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@

@include desktop-tablet {
.stk-block:is(.aligncenter, .alignwide, .alignfull) > .stk-content-align:not(.alignwide):not(.alignfull),
// Dev note: add selector for carousel because it has an extra wrapper before the inner blocks.
.stk-block-carousel:is(.aligncenter, .alignwide, .alignfull) > :where(.stk-block-carousel__content-wrapper) > .stk-content-align:not(.alignwide):not(.alignfull),
.stk-block .stk-block.aligncenter {
// --stk-block-default-width is a Stackable setting
// --stk-block-width-default-detected is from the fallback autodetected value.
Expand Down
4 changes: 3 additions & 1 deletion src/styles/editor-block.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@

// For wide/full width blocks, but with their contents center aligned.
:where(:is(.stk-preview-device-desktop, .stk-preview-device-tablet) [data-type^="stackable/"]:is([data-align="wide"], [data-align="full"]) > .stk-block > .stk-inner-blocks:not(.alignwide):not(.alignfull)),
:where(:is(.stk-preview-device-desktop, .stk-preview-device-tablet) [data-type^="stackable/"]:is([data-align="wide"], [data-align="full"]) [data-type^="stackable/"][data-align="center"]) {
:where(:is(.stk-preview-device-desktop, .stk-preview-device-tablet) [data-type^="stackable/"]:is([data-align="wide"], [data-align="full"]) [data-type^="stackable/"][data-align="center"]),
// Dev note: add selector for carousel because it has an extra wrapper before the inner blocks.
:where(:is(.stk-preview-device-desktop, .stk-preview-device-tablet) [data-type^="stackable/"]:is([data-align="wide"], [data-align="full"]) > .stk-block-carousel > :where(.stk-block-carousel__content-wrapper) > .stk-inner-blocks:not(.alignwide):not(.alignfull)) {
// --stk-block-default-width is a Stackable setting
// --stk-block-width-default-detected is from the fallback autodetected value.
max-width: var(--stk-block-default-width, var(--stk-block-width-default-detected, 900px)) !important;
Expand Down
Loading