make StandaloneOSX app runnable

[nathanleiby]

Potential fix for: #77

Questions:

• The contributor guidelines request adding tests, but given that this happens in the shell script I wasn't certain if/how to do that best. Any suggestions, or is a manual verification good enough?
• In the issue it discusses fixing Linux builds as well, but I haven't yet tested if they're broken or determined the path where the executable would need to be updated. Do we want to include that here as well or just Mac?

[codecov]

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          14       14           
  Lines         244      244           
  Branches       48       48           
=======================================
  Hits          231      231           
  Misses         13       13           

[nathanleiby]

After adding logging, I now see that it ran here (https://github.com/webbertakken/unity-builder/runs/760264818):

Making the following path executable: /github/workspace/build/StandaloneOSX/StandaloneOSX.app/Contents/MacOS/*

[webbertakken]

Looks good.

The contributor guidelines request adding tests, but given that this happens in the shell script I wasn't certain if/how to do that best. Any suggestions, or is a manual verification good enough?

Feel free to leave the tests for the bash part away.

In the issue it discusses fixing Linux builds as well, but I haven't yet tested if they're broken or determined the path where the executable would need to be updated. Do we want to include that here as well or just Mac?

I think it's OK to do the Linux part in a different PR as it's important to test these changes, since many people are using this.

[nathanleiby]

I recently pushed a commit to use the latest version of this github action (CleverGameDev/Cleverfall@5279802) and verified that the output is now executable (https://clevergamedev.itch.io/cleverfall).

NOTE: You still have do a security override to allow running a binary from unverified developer, but after that it works as expected vs hitting a 2nd error. This was expected; it's just standard MacOS security.

Thanks for shepherding this out! 🐑

[mastef]

@nathanleiby @webbertakken so I recently tried the MacOS build, and the resulting StandaloneOSX.app and the StandaloneOSX.app/Contents/MacOS/ProgramName were not executable. So double-clicking on the StandaloneOSX.app would come up with an error :

Trying to run it through terminal, would throw this error :

$ open StandaloneOSX.app/
LSOpenURLsWithRole() failed with error -10810 for the file /Downloads/Build/StandaloneOSX/StandaloneOSX.app.

After running chmod +x on both of them, I was able to open the app.

Maybe a regression is happening? Or the chmod +x is getting lost in the .zip?

[webbertakken]

@mastef thank you for reporting your issue.

Could you please open a new issue for this that is not closed and copy paste all information you've just provided?

That way also other contributors may be able to help.

[mastef]

@webbertakken I think re-opening #77 might be the better approach - as it seems to be a regression